chore: set rejectUnauthorized for api calls (#24087)

cypress-io · Oct 4, 2022 · d9c5e57 · d9c5e57 · cypress-bot · Oct 4, 2022
1 parent ed35eaa
commit d9c5e57
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/server/lib/api.js b/packages/server/lib/api.js
@@ -54,6 +54,7 @@ const rp = request.defaults((params = {}, callback) => {
     proxy: null,
     gzip: true,
     cacheable: false,
+    rejectUnauthorized: true,
   })
 
   const headers = params.headers != null ? params.headers : (params.headers = {})

diff --git a/packages/server/test/unit/api_spec.js b/packages/server/test/unit/api_spec.js
@@ -69,6 +69,20 @@ describe('lib/api', () => {
       })
     })
 
+    it('sets rejectUnauthorized on the request', () => {
+      nock.cleanAll()
+
+      return api.ping()
+      .thenThrow()
+      .catch(() => {
+        expect(agent.addRequest).to.be.calledOnce
+
+        expect(agent.addRequest).to.be.calledWithMatch(sinon.match.any, {
+          rejectUnauthorized: true,
+        })
+      })
+    })
+
     context('with a proxy defined', () => {
       beforeEach(function () {
         nock.cleanAll()