Skip to content

Commit

Permalink
chore: capture BUILDKITE_RETRY_COUNT (#25750)
Browse files Browse the repository at this point in the history
* misc: Capture BUILDKITE_RETRY_COUNT

* Add changelog

* Update code

* Update cli/CHANGELOG.md

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

---------

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
  • Loading branch information
estrada9166 and emilyrohrbough authored Mar 22, 2023
1 parent 6ba6200 commit 98c855e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ _Released 03/15/2023_

- Fixed a regression in Cypress [10](https://docs.cypress.io/guides/references/changelog#10-0-0) where the reporter auto-scroll configuration inside user preferences was unintentionally being toggled off. User's must now explicitly enable/disable auto-scroll under user preferences, which is enabled by default. Fixes [#24171](https://github.com/cypress-io/cypress/issues/24171) and [#26113](https://github.com/cypress-io/cypress/issues/26113).

**Misc:**

- Capture the [Buildkite](https://buildkite.com/) CI provider's environment variable `BUILDKITE_RETRY_COUNT` to handle CI retries in the Cloud. Addressed in [25750](https://github.com/cypress-io/cypress/pull/25750).

**Dependency Updates:**

- Upgraded [`ejs`](https://www.npmjs.com/package/ejs) from `3.1.6` to `3.1.8` to address this [CVE-2022-29078](https://github.com/advisories/GHSA-phwq-j96m-2c2q) NVD security vulnerability. Addressed in [#25279](https://github.com/cypress-io/cypress/pull/25279).
Expand Down
1 change: 1 addition & 0 deletions packages/server/lib/util/ci_provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ const _providerCiParams = () => {
'BUILDKITE_PULL_REQUEST',
'BUILDKITE_PULL_REQUEST_REPO',
'BUILDKITE_PULL_REQUEST_BASE_BRANCH',
'BUILDKITE_RETRY_COUNT',
]),
circle: extract([
'CIRCLE_JOB',
Expand Down
2 changes: 2 additions & 0 deletions packages/server/test/unit/util/ci_provider_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ describe('lib/util/ci_provider', () => {
BUILDKITE_PULL_REQUEST: 'buildkitePullRequest',
BUILDKITE_PULL_REQUEST_REPO: 'buildkitePullRequestRepo',
BUILDKITE_PULL_REQUEST_BASE_BRANCH: 'buildkitePullRequestBaseBranch',
BUILDKITE_RETRY_COUNT: 'buildkiteRetryCount',

BUILDKITE_COMMIT: 'buildKiteCommit',
BUILDKITE_BRANCH: 'buildKiteBranch',
Expand All @@ -311,6 +312,7 @@ describe('lib/util/ci_provider', () => {
expectsCiParams({
buildkiteRepo: 'buildkiteRepo',
buildkiteJobId: 'buildkiteJobId',
buildkiteRetryCount: 'buildkiteRetryCount',
buildkiteSource: 'buildkiteSource',
buildkiteBuildId: 'buildkiteBuildId',
buildkiteBuildUrl: 'buildkiteBuildUrl',
Expand Down

5 comments on commit 98c855e

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 98c855e Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.8.2/linux-arm64/develop-98c855e462a47b778e56e033959e104dc78aeb5a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 98c855e Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.8.2/linux-x64/develop-98c855e462a47b778e56e033959e104dc78aeb5a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 98c855e Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.8.2/darwin-x64/develop-98c855e462a47b778e56e033959e104dc78aeb5a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 98c855e Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.8.2/darwin-arm64/develop-98c855e462a47b778e56e033959e104dc78aeb5a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 98c855e Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.8.2/win32-x64/develop-98c855e462a47b778e56e033959e104dc78aeb5a/cypress.tgz

Please sign in to comment.