add cy.route2 recipe #555
Merged
add cy.route2 recipe #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
reviewed
Sep 9, 2020
examples/stubbing-spying__route2/cypress/integration/spy-on-fetch-spec.js
Show resolved
Hide resolved
flotwig
reviewed
Sep 9, 2020
flotwig
reviewed
Sep 9, 2020
flotwig
reviewed
Sep 9, 2020
|
Hehe pretty large oversight. Good thing someone tries to make a recipe for the users and catches it
…Sent from my iPhone
On Sep 9, 2020, at 12:29, Zach Bloomquist ***@***.***> wrote:
@flotwig commented on this pull request.
In examples/stubbing-spying__route2/cypress/integration/spy-on-fetch-spec.js:
> + // TODO: can we inspect the response object from the server?
+ // like response body...
ah yes, this is probably the result of a optimization where, if the response is not intercepted on the driver, it is not sent. but we still need it in the case of a .wait like this...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
bahmutov
commented
Sep 9, 2020
| }) | ||
|
|
||
| // NOTE: this does not work: cannot use cy commands inside the request handler | ||
| it.skip('shows loading indicator (alternative)', function () { |
There was a problem hiding this comment.
FYI the user wanted to do this, but we cannot (promise inside the code, etc) @flotwig
There was a problem hiding this comment.
@bahmutov see this issue: cypress-io/cypress#7667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shows the ergonomics and some weirdness around the new
cy.route2compared to the parallelcy.routerecipestubbing-spying__window-fetch