Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress-file-upload reference #272

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Add cypress-file-upload reference #272

merged 8 commits into from
Apr 19, 2019

Conversation

abramenal
Copy link
Contributor

@abramenal abramenal commented Apr 4, 2019

Add reference to plugin that makes file upload testing easy.
Supports upload via plain HTML input components, framework-specific file inputs, drag-n-drops, etc.
Usage recipe is located inside: https://github.com/abramenal/cypress-file-upload/tree/master/example

Cypress docs PR: cypress-io/cypress-documentation#1560

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abramenal
Copy link
Contributor Author

@jennifer-shehane can you please assist in merging the PR?

@jennifer-shehane
Copy link
Member

@bahmutov What's up with this ci/circleci: after-tests job?

@bahmutov
Copy link
Contributor

hmm, interesting why this is not being built on Circle, one sec

@bahmutov
Copy link
Contributor

ok, I think now it is working - for some reason we had "build forked pull request: Off" for this project on CircleCI

@abramenal
Copy link
Contributor Author

Okay now they are failing 😄

@bahmutov
Copy link
Contributor

no worries @abramenal - they are failing because we are not passing environment variables to forked pull requests, and the project is trying to record to Cypress Dashboard. I am fixing this.

@bahmutov bahmutov merged commit d8f099d into cypress-io:master Apr 19, 2019
@bahmutov
Copy link
Contributor

perfect, thank you @abramenal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants