chore: Use correctly typed missing value for lists #1686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes your package compatible with the next version of dplyr:
if_else()
now uses vctrs, which generally makes it more permissive when there are varying types, but it also means that the inputs must always be vectors. In dm's case,NULL
was being used as the missing type for lists, when reallylist(NULL)
needs to be used for vctrsIn dev dplyr, you could also just use
NA
now but that won't work with CRAN dplyr.We plan to submit dplyr 1.1.0 on January 27th.
This should be compatible with both dev and CRAN dplyr. It would help us out if you could go ahead and send a patch version of your package in ahead of time! Thanks!
Also, I think if you try and check this against dev dplyr right now then you'll see an additional failure related to
left_join()
and unused arguments. I think we are going to fix that in dplyr so it should go away.There are also some local failures related to join snapshots changing because of the
multiple = "all"
warning that is now thrown when a join results in multiple matches. When 1.1.0 is released you can just update the snapshots or setmultiple = "all"
explicitly