Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use correctly typed missing value for lists #1686

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

DavisVaughan
Copy link
Contributor

This PR makes your package compatible with the next version of dplyr:

  • if_else() now uses vctrs, which generally makes it more permissive when there are varying types, but it also means that the inputs must always be vectors. In dm's case, NULL was being used as the missing type for lists, when really list(NULL) needs to be used for vctrs

In dev dplyr, you could also just use NA now but that won't work with CRAN dplyr.

We plan to submit dplyr 1.1.0 on January 27th.

This should be compatible with both dev and CRAN dplyr. It would help us out if you could go ahead and send a patch version of your package in ahead of time! Thanks!


Also, I think if you try and check this against dev dplyr right now then you'll see an additional failure related to left_join() and unused arguments. I think we are going to fix that in dplyr so it should go away.

There are also some local failures related to join snapshots changing because of the multiple = "all" warning that is now thrown when a join results in multiple matches. When 1.1.0 is released you can just update the snapshots or set multiple = "all" explicitly

@krlmlr krlmlr changed the title Use correctly typed missing value for lists chore: Use correctly typed missing value for lists Dec 21, 2022
@krlmlr krlmlr merged commit 4a22d1b into cynkra:main Dec 21, 2022
@krlmlr
Copy link
Collaborator

krlmlr commented Dec 21, 2022

Thanks!

@krlmlr
Copy link
Collaborator

krlmlr commented Dec 21, 2022

Thanks Davis! We're running dm continuously against the dev version of dplyr, see, e.g., https://github.com/cynkra/dm/actions/runs/3745241278 . I'll take a look later today to make sure we're good when dplyr 1.1.0 is submitted.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants