Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps 2 #1000

Merged
merged 11 commits into from
May 5, 2022
Merged

Update deps 2 #1000

merged 11 commits into from
May 5, 2022

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Apr 29, 2022

🍾 #1000

I set up Renovate on my fork a while back and left it running to see how it got on. It managed to bump a few deps and generally seemed more advanced than dependabot e.g. it raised a PR to bump Vue to V2 raising a bunch of related deps at once. It also gives usage info and nice changelogs. Worth considering see #944.

The GraphiQL update seems to fix cylc/cylc-uiserver#328 for me.

@oliver-sanders oliver-sanders added this to the 1.2.0 milestone Apr 29, 2022
@oliver-sanders oliver-sanders self-assigned this Apr 29, 2022
@oliver-sanders
Copy link
Member Author

(rebased)

@oliver-sanders oliver-sanders added the dependencies Pull requests that update a dependency file label May 4, 2022
@oliver-sanders oliver-sanders marked this pull request as ready for review May 4, 2022 15:04
@oliver-sanders
Copy link
Member Author

Tested locally with GraphiQL, mutations, etc, looks good.

@datamel could you confirm if this fixes cylc/cylc-uiserver#328 for you?

@oliver-sanders oliver-sanders requested a review from MetRonnie May 4, 2022 15:04
@MetRonnie MetRonnie added the javascript Pull requests that update Javascript code label May 4, 2022
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working, haven't tested GraphiQL though, I guess it should be enough if you and Mel do

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as working (including GraphiQL) 👍

@hjoliver hjoliver merged commit a0a8a8e into cylc:master May 5, 2022
@oliver-sanders oliver-sanders deleted the update-deps-2 branch May 5, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphiql: subscriptions broken
5 participants