Test -S/--rose-template-variable
#310
Conversation
full test replicating original case
| cylc_install_cli, cylc_reinstall_cli, tmp_path, file_poll, | ||
| provide_template_vars_workflow, purge_workflow, cylc_stop | ||
| ): | ||
| """When we restart a workflow, the play CLI options are honoured. |
There was a problem hiding this comment.
@oliver-sanders - I've included this to demonstrate that I think that the clearance of the arguments shouldn't happen if the reload is one that comes with a restart since restart can have options set, unlike reload, and that if they are set then the user would expect the CLI variables to override those in the rose files, even if we have just reinstalled too.
| """Cylc stop & check the contact file""" | ||
| def _inner(id_): | ||
| run(split(f'cylc stop --now --now {id_}')) | ||
| contactfile = Path.home() / f'cylc-run{id_}.service/contact' |
There was a problem hiding this comment.
Shouldn't this be?
| contactfile = Path.home() / f'cylc-run{id_}.service/contact' | |
| contactfile = Path.home() / f'cylc-run/{id_}/.service/contact' |
Or better yet
from cylc.flow.workflow_files import get_contact_file_path| (tmp_path / 'flow.cylc').write_text( | ||
| '#!jinja2\n' | ||
| '[scheduling]\n' | ||
| ' [[graph]]\n' | ||
| ' R1 = foo\n' | ||
| '[runtime]\n' | ||
| ' [[foo]]\n' | ||
| ' script = cylc message -- {{var}}') | ||
| (tmp_path / 'rose-suite.conf').write_text( | ||
| '[template variables]\nvar="rose-suite.conf"') |
There was a problem hiding this comment.
N.B. I think it would be easier and cleaner to use a triple quoted string and textwrap.dedent()
| """Functional tests for reinstalling of config files. | ||
| This test does the following: | ||
|
|
||
| 1. Validates a workflow. | ||
| 2. Installs a workflow with some opts set using -O and | ||
| ROSE_SUITE_OPT_CONF_KEYS. | ||
| 3. Re-install workflow. | ||
| 4. After modifying the source ``rose-suite.conf``, re-install the flow again. | ||
|
|
||
| At each step it checks the contents of | ||
| - ~/cylc-run/temporary-id/rose-suite.conf | ||
| - ~/cylc-run/temporary-id/opt/rose-suite-cylc-install.conf | ||
| """ |
There was a problem hiding this comment.
This does not seem accurate. Copied from another test?
|
Closing becuase after an offline discussion it was decided to approach a totally different solution. |
Tests for cylc/cylc-flow#6065
Full explanation in that PR.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.