Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cli wrapper #297

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Test cli wrapper #297

merged 1 commit into from
Feb 26, 2024

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Feb 22, 2024

Built On: #276

Follow on from #276 (comment)

  • The install/reinstall commands used to be called via the CLI.
  • They were converted to run via the Python API, but some of the CLI wrapper legacy remained.
  • This strips away the CLI wrapper to make native Python testing easier.

For future work the validate fixture could receive a similar treatment.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders self-assigned this Feb 22, 2024
* The install/reinstall commands used to be called via the CLI.
* They were converted to run via the Python API, but some of the CLI
  wrapper legacy remained.
* This strips away the CLI wrapper to make native Python testing
  easier.
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good deal cleaner. 😄

@MetRonnie MetRonnie merged commit 4b24c03 into cylc:master Feb 26, 2024
9 checks passed
@oliver-sanders oliver-sanders deleted the test-cli-wrapper branch February 26, 2024 13:14
wxtim added a commit that referenced this pull request May 2, 2024
* upstream/master: (47 commits)
  simplify rose stem tests (#314)
  Apply suggestions from code review
  add developer docs
  build(deps): bump pypa/gh-action-pypi-publish from 1.8.11 to 1.8.14 (#301) [skip ci]
  tests: remove defunct cli wrappers (#297)
  tests/functional: fix scoping issues
  setup: add missing pytest-asyncio test dependency
  install/reinstall: adapt to new async interfaces
  tests: fix flaky text
  fileinstall: remove asyncio logic
  Bump codecov/codecov-action from 3 to 4 (#295)
  use fqdn in rose-stem tests (#294)
  Update setup.cfg
  setup: bump rose version
  fix merge mistake
  fix flake8
  fixed a test
  Apply suggestions from code review
  Bump actions/setup-python from 4 to 5 (#280)
  Update tests/functional/test_utils.py
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants