fix broken logic for template var selection

cylc/rose/stem.py

@@ -75,7 +75,7 @@
 )
 
 from cylc.rose.entry_points import get_rose_vars
-from cylc.rose.utilities import _identify_templating_section
+from cylc.rose.utilities import id_templating_section
 
 import metomi.rose.config
 from metomi.rose.fs_util import FileSystemUtil
@@ -455,7 +455,7 @@ def process(self):
             if i == 0:
                 template_type = get_rose_vars(
                     Path(url) / "rose-stem")["templating_detected"]
-                self.template_section = _identify_templating_section(
+                self.template_section = id_templating_section(
                     template_type, with_brackets=True)
 
             # Versions of variables with hostname prepended for working copies

cylc/rose/utilities.py

@@ -192,20 +192,22 @@ def identify_templating_section(config_node):
             "You should not define more than one templating section. "
             f"You defined:\n\t{'; '.join(defined_sections)}"
         )
+    elif defined_sections:
+        return id_templating_section(list(defined_sections)[0])
     else:
-        return id_templating_section(list(defined_sections)[0:1])
+        return id_templating_section('')
 
 
 def id_templating_section(
-    sections: Optional[str, None] = None,
+    section: Optional[str] = None,
     with_brackets: Optional[bool] = False
 ) -> str:
     """Return a full template section string."""
     templating = None
-        if section and 'jinja2' in section:
-            templating = 'jinja2:suite.rc'
-        elif section and 'empy' in section:
-            templating = 'empy:suite.rc'
+    if section and 'jinja2' in section:
+        templating = 'jinja2:suite.rc'
+    elif section and 'empy' in section:
+        templating = 'empy:suite.rc'
 
     if not templating:
         templating = 'template variables'

tests/unit/test_config_node.py

@@ -32,7 +32,7 @@
     deprecation_warnings,
     dump_rose_log,
     identify_templating_section,
-    _identify_templating_section,
+    id_templating_section,
     MultipleTemplatingEnginesError
 )
 
@@ -262,11 +262,10 @@ def test_identify_templating_section(node_, expect, raises):
         (['jinja2', True], '[jinja2:suite.rc]'),
     )
 )
-def test_identify_templating_section(input_, expect):
+def test_id_templating_section(input_, expect):
     assert id_templating_section(*input_) == expect
 
 
-
 @pytest.fixture
 def node_with_ROSE_ORIG_HOST():
     def _inner(comment=''):