Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename calendar switch to cycling #979

Merged
merged 6 commits into from
Jun 19, 2014

Conversation

arjclark
Copy link
Contributor

As per the earlier meeting, this renames "calendar" to "cycling mode".

@arjclark
Copy link
Contributor Author

@benfitzpatrick - please review (and test just in case!) asap.

@arjclark arjclark added this to the soon milestone Jun 17, 2014
@matthewrmshin matthewrmshin modified the milestones: cylc-6, soon Jun 18, 2014
@benfitzpatrick
Copy link
Contributor

I think the [scheduling]cycling option was intended to be renamed
cycling mode here, so that you get e.g. allowed options of integer,
iso8601, 360day.

@arjclark
Copy link
Contributor Author

[scheduling]cycling option?

@arjclark
Copy link
Contributor Author

Discussed with @hjoliver - will move all into one accordingly

@arjclark arjclark changed the title Rename calendar switch to cycling mode Rename calendar switch to cycling Jun 19, 2014
@arjclark
Copy link
Contributor Author

@benfitzpatrick - now all unified into the [scheduling]cycling option.

@benfitzpatrick
Copy link
Contributor

I've tested it, and cycling mode is definitely possible - a quick name change
would be good. See e.g.:
benfitzpatrick@145299e15
for my testing commit.

I also think '360' should indicate that it is date-time related,
somehow.

@arjclark
Copy link
Contributor Author

@benfitzpatrick - done.

@hjoliver
Copy link
Member

I think '360' should be '360 day'...

@arjclark
Copy link
Contributor Author

@benfitzpatrick - 360 day....

@hjoliver
Copy link
Member

huh? I mean cycling mode = 360 day (open to discussion of course)

@arjclark
Copy link
Contributor Author

Understood. Had just had a conversation with Ben about that.

benfitzpatrick added a commit that referenced this pull request Jun 19, 2014
Rename calendar switch to cycling
@benfitzpatrick benfitzpatrick merged commit 66cd85b into cylc:119.iso8601-cycling Jun 19, 2014
@arjclark arjclark deleted the cal_var_rename branch June 20, 2014 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants