Update isodatetime #897
Merged
Update isodatetime #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -393,27 +372,27 @@ def test_third_recurrence_format(self): | |||
| def test_fourth_recurrence_format(self): | |||
| """Test the fourth ISO 8601 recurrence format.""" | |||
| tests = [("PT6H/20000101T0500Z", "R/PT6H/20000101T0500Z"), | |||
| ("P12D/+P2W", "R/P12D/20010520T1200+0200"), | |||
There was a problem hiding this comment.
Note that all these changed because the timezone is now forced.
|
This ties into #887. |
|
@benfitzpatrick - the tests pass and I can't see any obvious problems. I figure that's a sufficiently thorough review given that we're not using isodatetime yet in cylc, but are just about to get started with it. I'll merge this now so I can get on with it ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Cylc with the latest isodatetime master
(see metomi/isodatetime#17).
The primary change is the addition of a much nicer dumping
API, which is demonstrated in
time_parser.pybelow.Another change is the restructuring of data model, parsers,
and tests into different modules - this mostly just means
e.g. using
data.TimePointwhere you usedTimePoint.@hjoliver, please review (mostly just the time_parser.py
changes - the others have been reviewed by @matthewrmshin).