-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cylc lint
S014: job runner specific timeout
#6137
cylc lint
S014: job runner specific timeout
#6137
Conversation
579c2d2
to
d24616b
Compare
d24616b
to
700eeec
Compare
700eeec
to
86d24c3
Compare
Marked my review comment as resolved but then it's hidden all the comments on the files, which are not resolved. Now I can't change the review comment to unresolved 😑 Please unhide the review and look at the comments |
Also should remove any instances of time limit directives from the docs? E.g.
|
This appears to only be an issue for SGE where a not below tells you not to do precisely this! n.b. Some of these directives still appear in documentation where examples of the job file show how the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing it doesn't pick up on is when multiple directives are specified on the same setting, e.g.
[[[directives]]]
-l = walltime=60:nodes=1
But otherwise I have tested and am happy with this
Not a pattern we see too often |
cylc lint
S014: job runner specific timeout
Closes #6131
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.