#119 - ISO 8601 inputs #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benfitzpatrick - looks really good. This does not yet affect anything else in cylc, and time is short, so I will merge it without a comprehensive review or testing at this stage - I hope that's ok. I'll take a much closer look when I begin working on using it throughout cylc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work for #119 and addresses the ISO 8601 wiki page.
It uses an ISO 8601 Python library for parsing and manipulating date/ time representations from https://github.com/metomi/isodatetime and implements some bridging code in cylc to implement our custom abbreviations and formatting. There is a fairly good range of tests.
This should allow us to start testing within cylc.
@hjoliver, please review.