cat-log: fix file listing errors #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
651b3c4 to
df4a6af
Compare
oliver-sanders
commented
May 4, 2023
| @@ -261,18 +261,18 @@ def view_log( | |||
| # Print location even if the workflow does not exist yet. | |||
| print(logpath) | |||
| return 0 | |||
| if not os.path.exists(logpath) and batchview_cmd is None: | |||
There was a problem hiding this comment.
The logpath contains the filename (defaults to job.out) even if it was not specified, even if we are listing a directory.
Consequently this caused failures when listing remote directories where the job.out file was not present.
df4a6af to
373b76a
Compare
wxtim
approved these changes
May 4, 2023
MetRonnie
approved these changes
May 4, 2023
|
Checked with GUI - I don't know what was wrong with my GUI locally, but I'm now satisfied that problems I was having are unrelated to this PR> |
* Include job-activity.log file if present even if listing is remote. * List local files for submission-failed tasks.
373b76a to
87457b7
Compare
|
One functional test failure: tests/f/platforms/10-platform-gone-on-restart.t (known to be flaky) |
wxtim
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.