Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cat-log: don't list directories which don't exist #5488

Merged
merged 1 commit into from
Apr 25, 2023
Merged

cat-log: don't list directories which don't exist #5488

merged 1 commit into from
Apr 25, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Apr 25, 2023 •
edited by MetRonnie
Loading

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • No CHANGES.md entry as the bug is unreleased
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the cylc-8.1.x milestone Apr 25, 2023
@oliver-sanders oliver-sanders self-assigned this Apr 25, 2023
MetRonnie
MetRonnie approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested out with the UI log view too and that works now

@MetRonnie MetRonnie added bug Something is wrong :( small labels Apr 25, 2023
@MetRonnie MetRonnie modified the milestones: cylc-8.1.x, cylc-8.1.3 Apr 25, 2023
@MetRonnie MetRonnie merged commit d34ae53 into cylc:8.1.x Apr 25, 2023
@MetRonnie MetRonnie linked an issue Apr 25, 2023 that may be closed by this pull request
cylc cat-log --mode=l traceback when log/install dir not present #5487
Closed
@oliver-sanders oliver-sanders deleted the 5487 branch April 25, 2023 12:06
wxtim added a commit to wxtim/cylc that referenced this pull request May 4, 2023
@wxtim
Merge remote-tracking branch 'upstream/8.1.x' into dont_get_platform_…
42205eb 
…too_soon

* upstream/8.1.x: (46 commits)
  Bump dev version (cylc#5518)
  Prepare release 8.1.4
  cat-log: fix issues with file listing
  Update changelog
  Fix `eval_host()` localhost bug & plug testing gap
  Bump dev version (cylc#5501)
  Prepare release 8.1.3
  Ignore off-sequence parents, for datastore. (cylc#5495)
  Avoid duplicate prerequisites from multiple recurrences. (cylc#5466)
  tests/f: fix events/11
  swarm: convert cylc-dev Docker image to run on ubuntu:latest
  fix changelog
  Apply prerequisite changes to spawned tasks, on reload & restart (cylc#5334)
  cat-log: don't list directories which don't exist (cylc#5488)
  task_job_mgr: move compute out of open call
  manylinux tests: update to ubuntu-20.04
  Update changelog
  Address review
  Fix.platform is regex remote tidy fail (cylc#5445)
  parsec: better error messages for section/setting mixups
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.1.3
Development

Successfully merging this pull request may close these issues.

cylc cat-log --mode=l traceback when log/install dir not present
2 participants
@oliver-sanders @MetRonnie