Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.platform is regex remote tidy fail #5445

Merged
merged 17 commits into from
Apr 21, 2023
Merged

Fix.platform is regex remote tidy fail #5445

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
53a10ed
Create a mapping between platforms and install_targets for use by rem…
wxtim Mar 29, 2023
af7d22e
Update tests/integration/test_task_remote_mgr.py
wxtim Mar 31, 2023
f498168
Removed new platforms method map_platforms_for_install_targets
wxtim Mar 31, 2023
dd2a373
Response to review
wxtim Mar 31, 2023
75a08f3
fix test
wxtim Apr 11, 2023
488bc58
response to review
wxtim Apr 17, 2023
35efbca
Update cylc/flow/exceptions.py
wxtim Apr 11, 2023
7a9da9f
Apply suggestions from code review
wxtim Apr 13, 2023
bf2a9e8
Merge remote-tracking branch 'upstream/8.1.x' into fix.platform_is_re…
wxtim Apr 17, 2023
7629ea6
f
wxtim Apr 17, 2023
812da58
fixed some logic
wxtim Apr 17, 2023
94a61da
review response
wxtim Apr 18, 2023
d99d688
Merge branch '8.1.x' into fix.platform_is_regex_remote_tidy_fail
wxtim Apr 19, 2023
ec9a531
Fix flake 8 failure
wxtim Apr 19, 2023
7e674d0
fixup test logic
wxtim Apr 20, 2023
4a86033
Update cylc/flow/exceptions.py
wxtim Apr 20, 2023
cda7a57
Update cylc/flow/task_job_mgr.py
wxtim Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions cylc/flow/task_remote_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,19 +316,18 @@ def _get_remote_tidy_targets(
A mapping of install targets to valid platforms only where
platforms are available.
"""
if not platform_names and install_targets:
if install_targets and not platform_names:
install_targets_map: Dict[str, List[Dict[str, Any]]] = {
t: [] for t in install_targets}
unreachable_targets = install_targets
else:
install_targets_map = get_install_target_to_platforms_map(
platform_names, quiet=True)
# If we couldn't find a platform for a target, we cannot tidy it -
# raise an Error:
unreachable_targets = install_targets.difference(
install_targets_map)

# If we couldn't find a platform for a target, we cannot tidy it -
# raise an Error:
unreachable_targets = [
t for t, v in install_targets_map.items()
if not v
] + list(install_targets.difference(install_targets_map))
if unreachable_targets:
msg = 'No platforms available to remote tidy install targets:'
for unreachable_target in unreachable_targets:
Expand Down