Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting of execution timeout based on execution time limit #4863

Merged
merged 1 commit into from
May 12, 2022
Merged

Remove setting of execution timeout based on execution time limit #4863

merged 1 commit into from
May 12, 2022

Conversation

dpmatthews
Copy link
Contributor

@dpmatthews dpmatthews commented May 9, 2022 •
edited
Loading

These changes close #4859

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Already covered by existing tests.
  • Appropriate change log entry included.
  • No documentation update required.

@dpmatthews dpmatthews force-pushed the execution-timeout branch from 21ff6a5 to c6dd6ee Compare May 9, 2022 17:05
@dpmatthews dpmatthews force-pushed the execution-timeout branch from c6dd6ee to 18921f5 Compare May 10, 2022 09:03
@dpmatthews dpmatthews marked this pull request as ready for review May 10, 2022 15:22
@dpmatthews dpmatthews added this to the cylc-8.0rc3 milestone May 10, 2022
hjoliver
hjoliver approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

But I'll hold off merging till you've considered this: #4859 (comment)

@dpmatthews dpmatthews mentioned this pull request May 12, 2022
Closed
@hjoliver hjoliver merged commit 127919b into cylc:master May 12, 2022
@wxtim wxtim mentioned this pull request Oct 13, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@dpmatthews dpmatthews

Labels
None yet
Projects
None yet
Milestone
cylc-8.0rc3
Development

Successfully merging this pull request may close these issues.

Investigate how execution timeout is set
3 participants
@dpmatthews @hjoliver @oliver-sanders