bump deprecation warnings from Cylc 9 to 8.x #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Logically Cylc 9 should come at the next configuration breaking change, however, that isn't planned for some time. (note the Python API should not break flow.cylc compatibility) * So we will remove back-support in the 8.x series rather than waiting for Cylc 9.
Historically, I bumped the major version along with "major" (and often internal) changes. However, the new way is better! |
hjoliver
approved these changes
May 4, 2022
6, 7 & 8 all had network layer changes which I think were also a valid reason to bump the major version. |
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
datamel
approved these changes
May 5, 2022
There was a problem hiding this comment.
Approving. No problems found for me. Thanks @oliver-sanders. Will merge after CI check.
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
May 6, 2022
…ins-localhost * expand_platforms_section: glblcfg: split comma separated platform definitions tests/u: parsec/test_util unittest->pytest bump deprecation warnings from Cylc 9 to 8.x (cylc#4853) Update tests/functional/execution-time-limit/04-polling-intervals.t Stop a few deprecation warnings in Cylc7 back compat mode Add tests Add polling interval test and change log entry. Set excecution polling delays correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[meeting 2022-05-04]
(note the Python API should not break flow.cylc compatibility)
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.