Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper pin markupsafe #4703

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Upper pin markupsafe #4703

merged 2 commits into from
Feb 21, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 21, 2022

ImportError: cannot import name 'soft_unicode' from 'markupsafe'

Jinja2 @ 2.11.3 has a dependency MarkupSafe>=0.23. Unfortunately Pallets have made a breaking change in the API in MarkupSafe 2.1.0, but have no plans to patch version 2.11 of Jinja2 with an upper pin on MarkupSafe, so we have to do it ourselves.

pallets/jinja#1585

Note: we have discussed moving to version 3.0 of Jinja2, which is the only supported version going forward (see comments from the Pallets team on the issue above). The difficulty is convincing ourselves this will not introduce breaking changes to Cylc workflows that are dependent on Jinja2. It is is unfeasible (and not our job) to write a test spec for Jinja2; however, it might be enough to have a suitably complex test workflow that we can diff with a reference file to see if Jinja2 updates cause changes in output.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Does not need tests
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR: Add note on markupsafe cylc-doc#408

@MetRonnie MetRonnie added bug Something is wrong :( non-cylc bug This is a bug, but not in Cylc labels Feb 21, 2022
@MetRonnie MetRonnie added this to the cylc-8.0rc2 milestone Feb 21, 2022
@MetRonnie MetRonnie self-assigned this Feb 21, 2022
@oliver-sanders oliver-sanders removed the bug Something is wrong :( label Feb 21, 2022
@MetRonnie
Copy link
Member Author

@oliver-sanders
Copy link
Member

oliver-sanders commented Feb 21, 2022

The manylinux failure is due to a combination of kiwisolver dropping manylinux1 support and pip22 failing on error (so no longer falling back to the previous version as it used to).

The (transient) kiwisolver dep is kiwisolver>=1.0.1, manylinux support was only dropped at the most recent 1.3.2 release so we are good here, for now...

This might be enough to patch things over for now #4704

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying, but valid·

@wxtim wxtim removed the request for review from hjoliver February 21, 2022 16:53
@wxtim wxtim merged commit f224be7 into cylc:master Feb 21, 2022
@MetRonnie MetRonnie deleted the markupsafe branch February 21, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-cylc bug This is a bug, but not in Cylc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants