Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja2 @ 2.11.3 has a dependency
MarkupSafe>=0.23
. Unfortunately Pallets have made a breaking change in the API in MarkupSafe 2.1.0, but have no plans to patch version 2.11 of Jinja2 with an upper pin on MarkupSafe, so we have to do it ourselves.pallets/jinja#1585
Note: we have discussed moving to version 3.0 of Jinja2, which is the only supported version going forward (see comments from the Pallets team on the issue above). The difficulty is convincing ourselves this will not introduce breaking changes to Cylc workflows that are dependent on Jinja2. It is is unfeasible (and not our job) to write a test spec for Jinja2; however, it might be enough to have a suitably complex test workflow that we can diff with a reference file to see if Jinja2 updates cause changes in output.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.