-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tui: bug fixes #4670
tui: bug fixes #4670
Conversation
0c19ab8
to
9777156
Compare
9777156
to
cd9561f
Compare
Poking tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out manually, fixes the reported bugs.
Only thing is there is a delay of a couple of seconds between hitting enter on one of the offline commands in the menu and the menu closing
That's the time it takes for the command to run (blocking). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Can confirm that this definitely fixes #4654 , #4647 and #4629.
I'm concerned about the bug shown below, although it might want spinning into a new bug report:
output.mp4
Essentially - stop
returns control to you before the mutation finishes, and you can bring back the menu and ask for stop a second time after the workflow has stopped, and this causes a crash with traceback. Mentioned here rather than a separate issue because traceback refers to Exception raised by code in this PR.
@oliver-sanders your choice whether you want to fix or log this bug. I'm otherwise happy enough that this answers its original purpose that it can go in.
^ there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot reproduce the bug Tim identified with the latest commit.
(Oh, it's already been merged!)
tui: add offline commands
zmq client: raise WorkflowStoped not ClientTimeout
tui: disable mutations for stopped workflows
tui: fix context menu for cycle points
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.