Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PBS 19.2.1+ job names. #4540

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Handle PBS 19.2.1+ job names. #4540

merged 3 commits into from
Dec 7, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Dec 1, 2021

These changes close #4539

@dpmatthews - is this simple fix sufficient?

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • covered by existing tests (presumbably, covered by PBS test if run using recent PBS versions)?
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver added this to the cylc-8.0rc1 milestone Dec 1, 2021
@hjoliver hjoliver self-assigned this Dec 1, 2021
@hjoliver hjoliver added the bug Something is wrong :( label Dec 1, 2021
@hjoliver hjoliver requested a review from dpmatthews December 7, 2021 04:37
Copy link
Contributor

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this fixes the problem

@datamel datamel self-requested a review December 7, 2021 09:29
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code read, branch checked out and I have confirmed the flaky test that was failing passes locally for me. I have re-run the checks and it is now passing.
No change log entry as yet, otherwise looks good to me.

@hjoliver
Copy link
Member Author

hjoliver commented Dec 7, 2021

Change log updated.

@hjoliver hjoliver merged commit bf29f00 into cylc:master Dec 7, 2021
@hjoliver hjoliver deleted the pbs-tweak branch December 7, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cylc 8 job name not compatible with PBS 19.2.1+
3 participants