Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job polling bug. #4443

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Fix job polling bug. #4443

merged 2 commits into from
Oct 7, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Oct 1, 2021

Manual cherry-pick 6ea4947 from #4437
Credit @wxtim

Close #4431

Bug reproduced on master with this workflow and time.sleep(10) between status file and job runner check in job_runner_mgr.py:

[scheduling]
    [[graph]]
        R1 = "poller & fast & waiter"
[runtime]
    [[poller]]
        script = cylc poll $CYLC_WORKFLOW_NAME fast.1
    [[fast]]
        init-script = sleep 5  # fake delayed start
    [[waiter]]
        script = "cylc__job__poll_grep_workflow_log '\(polled\)'"

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and conda-environment.yml (none)
  • Does not need tests (note testable without bodging the code).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@hjoliver hjoliver added the bug Something is wrong :( label Oct 1, 2021
@hjoliver hjoliver added this to the cylc-8.0b3 milestone Oct 1, 2021
@hjoliver hjoliver self-assigned this Oct 1, 2021
@hjoliver hjoliver requested review from dpmatthews and wxtim October 1, 2021 02:20
Copy link
Contributor

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced problem with Cylc 8 and confirmed this fixes it.

@wxtim
Copy link
Member

wxtim commented Oct 7, 2021

@dpmatthews Any particular reason you didn't merge it?

@wxtim wxtim merged commit 577a895 into cylc:master Oct 7, 2021
@hjoliver hjoliver deleted the fix-job-poll-master branch October 8, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polling can result in incorrect submit-failed
3 participants