Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with task name as substring of task name. #4426

Merged
merged 6 commits into from
Sep 23, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Sep 23, 2021

These changes close #3664

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver self-assigned this Sep 23, 2021
@hjoliver hjoliver added the bug Something is wrong :( label Sep 23, 2021
@hjoliver hjoliver added this to the cylc-8.0b3 milestone Sep 23, 2021
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on master and got a strange xbool.

['bool(self.satisfied[("foo", "1", "succeeded")])', 'xbool(self.satisfied[("foo", "1", "succeeded")])']

Switched to this branch, and now got the correct result as per doctests.

['bool(self.satisfied[("foo", "1", "succeeded")])', 'bool(self.satisfied[("xfoo", "1", "succeeded")])']

Minor comment, but looks good to me! Thanks @hjoliver

@hjoliver
Copy link
Member Author

Tested on master and got a strange xfoo.

I think you pasted the wrong line there? The error case should have xbool in it, due to a bad string replacement.

@kinow
Copy link
Member

kinow commented Sep 23, 2021

Tested on master and got a strange xfoo.

I think you pasted the wrong line there? The error case should have xbool in it, due to a bad string replacement.

Ops, copied from the wrong section from the terminal output, fixed! Thanks.

Co-authored-by: Bruno P. Kinoshita <kinow@users.noreply.github.com>
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced bug on master, couldn't on this branch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conditional prerequisite bug
3 participants