-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with task name as substring of task name. #4426
Conversation
a506578
to
efd6ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on master
and got a strange xbool
.
['bool(self.satisfied[("foo", "1", "succeeded")])', 'xbool(self.satisfied[("foo", "1", "succeeded")])']
Switched to this branch, and now got the correct result as per doctests.
['bool(self.satisfied[("foo", "1", "succeeded")])', 'bool(self.satisfied[("xfoo", "1", "succeeded")])']
Minor comment, but looks good to me! Thanks @hjoliver
I think you pasted the wrong line there? The error case should have |
Ops, copied from the wrong section from the terminal output, fixed! Thanks. |
Co-authored-by: Bruno P. Kinoshita <kinow@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced bug on master, couldn't on this branch 👍
These changes close #3664
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.