Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan: use natural sort order with --sort opt #4346

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Aug 10, 2021

Use natural sort order with cylc scan.

Place function in generic module for easy reuse.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@oliver-sanders oliver-sanders added this to the cylc-8.0b3 milestone Aug 10, 2021
@oliver-sanders oliver-sanders self-assigned this Aug 10, 2021
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read
  • Cylc Scan --sort appears to work
  • Poked the code

The only extra I can think of is including an example where the strings look like Python Hex, Oct and Binary numbers, but not essential.

@MetRonnie MetRonnie merged commit acc68de into cylc:master Aug 11, 2021
@oliver-sanders oliver-sanders deleted the scan-sort branch August 12, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants