Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scan: show uninstalled workflows #4286

Merged
merged 1 commit into from
Jul 15, 2021
Merged

scan: show uninstalled workflows #4286

merged 1 commit into from
Jul 15, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jul 1, 2021 •
edited
Loading

Add the cylc scan --uninstalled option.

Note: Source isn't a workflow state because source workflows are orthogonal to run workflows. The lifecycle of the source is not the same as the lifecycle of the run. The UI will have to track source and run workflows separately.

First step towards displaying source workflows in the UI (as the UIS can use the scan_multi interface). Next we need to jam source workflows into the schema at the UIS and make them available to the UI.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR at cylc/cylc-doc/pull/XXXX.

@oliver-sanders oliver-sanders added this to the cylc-8.0b2 milestone Jul 1, 2021
@oliver-sanders oliver-sanders self-assigned this Jul 1, 2021
MetRonnie
MetRonnie reviewed Jul 2, 2021
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/conftest.py
monkeypatch.setattr(pypath, _inner)

yield _mock
rmtree(tmp_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was here before, but is the rmtree(tmp_path) actually needed? Doesn't tmp_path get removed anyway afterwards?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is needed.

datamel
datamel approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the code, checked out the branch, manually tested the change and run the tests. Thanks @oliver-sanders.

@oliver-sanders oliver-sanders force-pushed the scan-installed branch 3 times, most recently from 06b7ba5 to a322a6a Compare July 5, 2021 15:17
MetRonnie
MetRonnie approved these changes Jul 12, 2021
View reviewed changes
@oliver-sanders
Copy link
Member Author

Merging with two approvals.

@oliver-sanders oliver-sanders merged commit 7346279 into cylc:master Jul 15, 2021
@oliver-sanders oliver-sanders deleted the scan-installed branch July 15, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
cylc-8.0b2
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @datamel @MetRonnie