config: validate [runtime] task names #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
commented
Apr 27, 2021
Comment on lines
+56
to
+61
| validate = partial( | ||
| WorkflowConfig, | ||
| reg, | ||
| str(Path(run_dir, reg, 'flow.cylc')), | ||
| ValidateOptions() | ||
| ) |
There was a problem hiding this comment.
Performing a full validation rather than just calling the TaskNameValidator directly as the reported bug is more nuanced.
|
Looks good, apart from need to handle parameterised names |
Parameters are expanded out before the names are validated. |
kinow
approved these changes
Apr 27, 2021
kinow
approved these changes
Apr 27, 2021
How did you generate that error @MetRonnie ? |
|
It was in the tests, fixed now |
MetRonnie
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3160
Validate task names in the
[runtime]section, autodocument from this code (corrects the docs on valid task name patterns).Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.