Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cylc install help examples #4188

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Apr 21, 2021

These changes close #4186

Would be good to get this in for 8.0b1

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (can't test these automatically).
  • Appropriate change log entry included.
  • No documentation update required.
  • No dependency changes.

@MetRonnie MetRonnie added bug Something is wrong :( small doc Documentation labels Apr 21, 2021
@MetRonnie MetRonnie added this to the cylc-8.0b1 milestone Apr 21, 2021
@MetRonnie MetRonnie self-assigned this Apr 21, 2021
@MetRonnie MetRonnie requested review from datamel and wxtim April 21, 2021 08:17
@MetRonnie MetRonnie changed the title Fix cylc install help examples [skip ci] Fix cylc install help examples Apr 21, 2021
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MetRonnie. Tested as working.

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried following instructions and it didn't work as expected...

@MetRonnie MetRonnie requested review from wxtim, hjoliver and kinow April 21, 2021 14:58
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me too.

(venv) kinow@ranma:~/Development/python/workspace/cylc-flow$ cd ~/cylc-suites
(venv) kinow@ranma:~/cylc-suites$ mkdir -p bunny/rabbit
(venv) kinow@ranma:~/cylc-suites$ touch bunny/rabbit/flow.cylc
(venv) kinow@ranma:~/cylc-suites$ cylc install --directory=bunny/rabbit
INSTALLED rabbit from bunny/rabbit -> /home/kinow/cylc-run/rabbit/run1

@hjoliver hjoliver merged commit d5b34a1 into cylc:master Apr 21, 2021
@MetRonnie MetRonnie deleted the fix-install-help branch April 22, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( doc Documentation small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix install examples
5 participants