Fixed platforms subsequent cycles on localhost. #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86fde66 to
cdc064b
Compare
Discovered a bug where host ⇒ plaform upgrade only worked on first cycle.
Cause: becuase Python passes refs rather than creating objects the upgrader
function popped the required info for the first instance of a task.
Fix: have `platform_from_job_info` put popped information back when it's
finished.
cdc064b to
2460e69
Compare
MetRonnie
reviewed
Apr 12, 2021
tests/functional/platforms/02-host-to-platform-upgrade/flow.cylc
Outdated
Show resolved
Hide resolved
MetRonnie
reviewed
Apr 12, 2021
MetRonnie
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
LGTM, with one small suggestion. I've run the fast tests locally, and tests/f/platforms/02-host-to-platform-upgrade. Keeping an eye on the running func tests here https://github.com/cylc/cylc-flow/actions/runs/743942309
It may be necessary to take any that fail on Actions due to DNS and run them locally
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
oliver-sanders
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Ran the "fast tests" locally, all passed (GH failures due to DNS issues):
cylc.flow.exceptions.ClientTimeout: Timeout waiting for server response. This could be due to network or server issues. Check the suite log.
Can ignore for now (with local testing).
Looks good.
Tested locally with:
[remote]
[[t1]]
[[[job]]]
batch system = background
[[t2]]
[[[remote]]]
host = myremote
[[t3]]
platform = myremoteOver multiple cycles and submission batches, all good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug where host ⇒ plaform upgrade only worked on first cycle.
Cause: becuase Python passes refs rather than creating objects the upgrader
function popped the required info for the first instance of a task.
Fix: have
platform_from_job_infoput popped information back when it'sfinished.
These changes close #4167
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.