Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install rose suite.conf in cylc rose #4094

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Install rose suite.conf in cylc rose #4094

merged 3 commits into from
Feb 26, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Feb 23, 2021 •
edited
Loading

These changes close Cylc-rose issue 36 in combination with Cylc Rose PR 38

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests - Testing carried out in Cylc Rose. The main test for this is that existing tests are not broken.
  • No change log entry required - Invisible to users - no real change in functionality, just a change in how the task is carried out.
  • No documentation update required.
  • No dependency changes.

@wxtim wxtim self-assigned this Feb 23, 2021
@wxtim wxtim added this to the cylc-8.0b0 milestone Feb 23, 2021
@wxtim wxtim changed the title added rose suite conf to ingnore list Install rose suite.conf in cylc rose Feb 25, 2021
This was referenced Feb 26, 2021
Closed
Merged
Merged
Closed
@wxtim wxtim requested a review from MetRonnie February 26, 2021 10:24
@oliver-sanders
Copy link
Member

Can push this tiny change with one review.

@oliver-sanders oliver-sanders merged commit 9784733 into cylc:master Feb 26, 2021
@wxtim wxtim deleted the install-rose-suite.conf-in-cylc-rose branch February 26, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.

Install rose-suite.conf in cylc rose
2 participants
@wxtim @oliver-sanders