Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ready -> preparing. #4014

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Rename ready -> preparing. #4014

merged 4 commits into from
Jan 11, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Dec 23, 2020 •
edited
Loading

Easiest part of the task state rationalization (just a one-to-one renaming)

These changes partially address #4013

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • Appropriate change log entry included.
  • (master branch) covered by doc issue Document new task states cylc-doc#163
  • No dependency changes.

@hjoliver hjoliver added this to the cylc-8.0b0 milestone Dec 23, 2020
@hjoliver hjoliver self-assigned this Dec 23, 2020
This was referenced Dec 23, 2020
Closed
Merged
@oliver-sanders
Copy link
Member

One line diff in tests/f/graphql/01-workflow.t

hjoliver and others added 3 commits January 11, 2021 14:51
@hjoliver @oliver-sanders
Update cylc/flow/tui/__init__.py
bafb56e 
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@hjoliver
Fix tests.
c14e28a
@hjoliver
Update change log.
ed6ac9a
@hjoliver
Copy link
Member Author

Tests fixed.

@hjoliver hjoliver requested a review from kinow January 11, 2021 01:58
@hjoliver
Copy link
Member Author

@kinow this is the cylc-flow sibling of cylc/cylc-ui#564

@kinow
Copy link
Member

kinow commented Jan 11, 2021

@kinow this is the cylc-flow sibling of cylc/cylc-ui#564

Oh, missed this one, thanks @hjoliver !

@oliver-sanders oliver-sanders merged commit c2f6942 into cylc:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@hjoliver hjoliver

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
3 participants
@hjoliver @oliver-sanders @kinow