-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: coverage #3923
actions: coverage #3923
Conversation
8f4e18f
to
3365413
Compare
3365413
to
2b89773
Compare
bc9bf7c
to
560353b
Compare
560353b
to
2219726
Compare
fc431cb
to
bc1d324
Compare
9ba2897
to
044faee
Compare
044faee
to
7f2d045
Compare
Deconflicted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/unit/main_loop/auto_restart.py → tests/unit/main_loop/test_auto_restart
has lost its extension. Other suggestions optional
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
else: | ||
if version: | ||
cmd_args.append("--version") | ||
execute_cmd(command, *cmd_args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 great workaround !
closes: #3598
follow on from: #3899
Reinstates code coverage for Cylc.
It does:
cylc
commands.It does not:
cylc
library from Python (i.e. not via thecylc
CLI).coverage
,pytest --cov
, etc).--no-detach
is not set).For assurance that a
cylc
command is being captured and covered setCYLC_COVERAGE=2
, you will get a.coverage_commands_captured
file which lists each command for which coverage was successfully recorded.Initial results suggest we have ~89.5% coverage with obvious holes in the coverage around remote functionality, for now...
...Remote results in, 91.22%, not bad.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.