Fix bad host test #3917
Merged
Fix bad host test #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…environments where a different error code and message are returned (this can happen for instance when a VPN is in use). Also rewrote test to use a context manager (this will prevent the test from incorrectly passing if no exception is thrown)
kinow
approved these changes
Nov 4, 2020
Comment on lines
+98
to
+99
| [#3917](https://github.com/cylc/cylc-flow/pull/3917) - Fix a bug that caused one of the hostname resolution tests to fail in certain environments. | ||
|
|
There was a problem hiding this comment.
BTW: We try to keep the changelog focused on user-facing changes (especially as there is going to be a very long list of changes for Cylc8), no probs though.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the test test_get_fqdn_by_host_on_bad_host to check the exception thrown by socket.gethostbyname_ex using a regex to account for variations in error message returned in different environments.
Also changed the test to use a context manager to test whether an exception is raised. This should prevent the test from incorrectly passing if no exception is thrown.
These changes close #3916.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.