Remove checkpointing #3906
Remove checkpointing #3906
Conversation
405338e to
0eb2b03
Compare
9089304 to
85d8fc2
Compare
| self.n_restart = pri_dao.select_suite_params_restart_count() + 1 | ||
| self.put_suite_params_1(self.KEY_RESTART_COUNT, self.n_restart) | ||
| pri_dao.close() |
There was a problem hiding this comment.
Setting this as a property of the suite database manager class feels a bit weird, but I couldn't rely on reading the updated value from the database from the scheduler, because this "put" operation is merely queued and doesn't get executed until after the scheduler has already logged the number of restarts
85d8fc2 to
1428dd3
Compare
|
In terms of documentation, I suspect that this would be better left to the 7-to-8 guide or whoever writes up reflow in the docs? |
|
New cylc-doc Issue for 7-8 migration, with a checkbox for this topic: cylc/cylc-doc#170 |
There was a problem hiding this comment.
Nothing Major to say - just my usual pickyness about docstrings.
You have a deconfliction to-do, and you can probably free up @oliver-sanders or @hjoliver from this review.
d675e67 to
6c07d9f
Compare
These changes close #3891
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.