Move max active cycle points behaviour into runahead limit
#3848
Conversation
| ({'cycling mode': 'integer', 'runahead limit': 'PT12H'}, False), | ||
| ({'cycling mode': 'integer', 'runahead limit': 'P7D'}, False), | ||
| ({'cycling mode': 'integer', 'runahead limit': '4'}, False), | ||
| ({'cycling mode': 'gregorian', 'runahead limit': ''}, False), |
There was a problem hiding this comment.
It is not possible to set runahead limit to null
There was a problem hiding this comment.
Sensible, an infinite runahead limit is a whole other kettle of fish!
cylc/flow/cfgspec/suite.py
Outdated
| This limit on the number of consecutive cycle points is specified | ||
| by an interval between the least and most recent: either an integer | ||
| interval (e.g. ``P3`` - works for both :term:`integer cycling` and | ||
| :term:`datetime cycling`), or a time interval (e.g. ``PT12H`` - | ||
| only works for datetime cycling). Alternatively, if a raw number is | ||
| given, it will be taken to mean that number of hours, though this | ||
| usage is deprecated. |
There was a problem hiding this comment.
I don't think this format of Pn (e.g. P3) for a number limit is good, because if you have
[[graph]]
P2 = foo # where foo failsThat means the cycle points will be foo.1, foo.3, foo.5 etc. But the runahead limit will stall at foo.5 not foo.3 because foo.5 is actually the 3rd cycle point.
So runahead limit = 3 instead of P3 would make more sense. But the trouble is it would break the backwards compatibility where the raw number is interpreted as PT3H
There was a problem hiding this comment.
It wouldn't break backwards compatibility because this issue only occurs in integer cycling mode. It might make it a bit harder to parse the value though.
There was a problem hiding this comment.
Are you suggesting interpreting a raw number as number of cycle points for integer mode, and number of hours for datetime mode? Seems messy to me 😬
There was a problem hiding this comment.
The alternatives would be:
- Stick with
P<n>, just document the hell out of it. - Come up with another prefix character (confusing).
There was a problem hiding this comment.
Stick with
P<n>, just document the hell out of it.
That seems the best option to me, if we can't afford to lose the raw hours back compat.
There was a problem hiding this comment.
Sadly the old feature was never actually deprecated and is widely used.
| T04 = "run_ok & fail" | ||
| T04 = "run_ok" | ||
| # T05... | ||
| T05 = "run_ok_2 & fail" | ||
| T05 = "run_ok_2" |
There was a problem hiding this comment.
It doesn't matter whether these succeed or fail, as foo.T00 has already failed, so that is what limits the runahead
- runahead limit can now be used for number of consecutive cycle pts (or - the pre-existing behaviour - time interval between oldest and newest cycle pts) - max active cyle points is currently disabled until a non-consecutive implementation is ready
Because moved `max active cycle pt` behaviour to `runahead limit` - Changed default from 3 to 5 - Fixed tests where it was looking up (from the db) the max cycle point in the runahead pool instead of just the task pool
… limiting Also change it to an integer cycling workflow as all the other runahead tests already test datetime cycling
e.g. runahead limit = PT4H
a1efe75 to
b1d8ba2
Compare
b1d8ba2 to
112f88c
Compare
112f88c to
88f3c4b
Compare
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
|
(pycodestyle failed; I'll fix that in my add-a-comment follow-up). |
These changes partially address #3667
The functionality of setting a runahead limit of a certain number of consecutive cycle points is being moved from
[scheduling]max active cycle pointsto[scheduling]runahead limit.In future,
max active cycle pointswill set a limit on non-consecutive cycle points (see #3667 (comment) for info on the difference between consecutive and non-consecutive limits), but this is not implemented in this PR. Edit:max active cycle pointsis being deprecated and a new setting will set the non-consecutive limit.Examples:
max active cycle points = 3runahead limit = P3runahead limit = PT12HRequirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.max active cycle pointsin favor ofrunahead limitcylc-doc#161