Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename _rc -> _config #3786

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Rename _rc -> _config #3786

merged 1 commit into from
Aug 25, 2020

Conversation

MetRonnie
Copy link
Member

A few things slipped the net in #3755

These changes partially address #3689

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (simple renaming).
  • No change log entry required (invisible to users).
  • No documentation update required.
  • No dependency changes.

@MetRonnie MetRonnie added this to the cylc-8.0a3 milestone Aug 24, 2020
@MetRonnie MetRonnie requested a review from wxtim August 24, 2020 12:14
@MetRonnie MetRonnie linked an issue Aug 24, 2020 that may be closed by this pull request
conf: configuration file changes #3689
Closed
5 tasks
@wxtim wxtim merged commit b397d97 into cylc:master Aug 25, 2020
@MetRonnie MetRonnie deleted the config-changes-followup branch August 25, 2020 10:26
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim wxtim approved these changes

Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.

conf: configuration file changes
3 participants
@MetRonnie @hjoliver @wxtim