Remove interactive prompt support #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be on 8.0a3 or 8.0.0 milestone? |
|
It looks like the functional tests are still running 👀 probably fixed by #3775 . |
As you already have the code ready, and it is not a change with high risk, I think we can leave it in 8.0a3. |
kinow
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Code looks good.
Tested master first (never had used that interactive mode):
(venv) kinow@ranma:~/Development/python/workspace/cylc-flow$ cylc poll five --verbose
2020-08-14T12:53:50+12:00 DEBUG - Loading site/user config files
2020-08-14T12:53:50+12:00 DEBUG - Reading file /home/kinow/.cylc/flow/8.0a3.dev/flow.rc
Poll ALL tasks in five (y/n)? nThen this branch.
(venv) kinow@ranma:~/Development/python/workspace/cylc-flow$ cylc poll five --verbose
2020-08-14T12:54:11+12:00 DEBUG - Loading site/user config files
2020-08-14T12:54:11+12:00 DEBUG - Reading file /home/kinow/.cylc/flow/8.0a3.dev/flow.rc
2020-08-14T12:54:11+12:00 WARNING - deprecated items were automatically upgraded in 'user config':
2020-08-14T12:54:11+12:00 WARNING - * (8.0.0) [disable interactive command prompts] - DELETED (OBSOLETE)
2020-08-14T12:54:11+12:00 DEBUG - zmq:send {'command': 'poll_tasks', 'args': {'tasks': (), 'poll_succeeded': False}, 'meta': {'prog': 'cylc-poll', 'host':
'ranma'}}
2020-08-14T12:54:11+12:00 DEBUG - zmq:recv {'data': [True, 'Command queued'], 'user': 'kinow'}Searched code for "interactive" and "force", and found no other occurrences related to this change I think. And also found nothing in cylc-docs. 👍 +1
|
(Restarted the tests) |
|
The functional tests are weirdly hanging here 🤔 |
kinow
reviewed
Aug 14, 2020
f691118 to
6564b25
Compare
|
Note: Update: So is |
6564b25 to
da7b96a
Compare
da7b96a to
fc0daa3
Compare
|
Finally managed to fix the tests! |
kinow
approved these changes
Aug 14, 2020
hjoliver
approved these changes
Aug 14, 2020
oliver-sanders
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #3693
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.