Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtriggers: validate labels (master) #3732

Merged
merged 3 commits into from
Aug 9, 2020
Merged

xtriggers: validate labels (master) #3732

merged 3 commits into from
Aug 9, 2020

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Aug 4, 2020 •
edited
Loading

C-lose #3703 (master)
Companion to: cylc/cylc-doc#140

Validate xtrigger names to prevent nasty runtime issues.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR at validate xtrigger labels cylc-doc#140.
  • No dependency changes.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Aug 4, 2020
@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Aug 4, 2020
@oliver-sanders oliver-sanders self-assigned this Aug 4, 2020
@oliver-sanders oliver-sanders mentioned this pull request Aug 4, 2020
Merged
@oliver-sanders oliver-sanders mentioned this pull request Aug 4, 2020
Merged
6 tasks
@oliver-sanders oliver-sanders changed the title xtriggers: validate labels xtriggers: validate labels (master) Aug 4, 2020
hjoliver
hjoliver reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as advertised.

[x] Appropriate tests are included (unit and/or functional).

(But I don't see these)

@oliver-sanders
Copy link
Member Author

Dam, didn't git add it...

@hjoliver hjoliver requested a review from kinow August 9, 2020 19:48
@kinow kinow merged commit 6168bf3 into cylc:master Aug 9, 2020
@oliver-sanders oliver-sanders deleted the 3703.xtrigger-name-validation branch August 10, 2020 08:14
@MetRonnie MetRonnie mentioned this pull request Dec 10, 2020
Closed
7 tasks
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @kinow @hjoliver