xtrigger sequence fix - master #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
suggested changes
Aug 12, 2019
c418a21 to
aef57b9
Compare
ccfab39 to
f5a1f10
Compare
|
This branch still needs a change log entry, and several unit tests have failed - should be easy to fix as soon as I have time to get back to it. |
820ef9a to
3eaa891
Compare
|
This should now be good to go @matthewrmshin (if tests pass...). Pinging @kinow for 2nd review, as he helped out with the unit tests (thanks for that 👍!) |
|
(Note #3285 - same change on 7.8.x - already merged). |
kinow
suggested changes
Aug 28, 2019
hjoliver
commented
Aug 28, 2019
147a021 to
1e2d88d
Compare
|
All feedback addressed and tests fixed (let's see if Travis CI agrees ...) |
kinow
approved these changes
Aug 29, 2019
|
Ah crap, good spotting. I suspect I missed a commit between work and home computers, and did a force push. |
|
(Re)fixed. |
matthewrmshin
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master companion of #3285
These changes (along with #3285) close #3283
TODO:
some basic Python 3 upgrade (e.g. format strings)fix some xtrigger unit testsRequirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.