Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support symlinked alternate run directories (cylc 7). #3203

Merged
merged 8 commits into from
Aug 30, 2019
Merged

Support symlinked alternate run directories (cylc 7). #3203

merged 8 commits into from
Aug 30, 2019

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Jun 30, 2019 •
edited
Loading

7.8.x back-port of #2935

Addresses #2797.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (functional).
  • Includes an appropriate entry in the release change log CHANGES.md.
  • Includes an appropriate documentation update.

@hjoliver hjoliver added this to the next-release milestone Jun 30, 2019
@hjoliver hjoliver changed the title Support symlinked alternate run directories. Support symlinked alternate run directories (cylc 7). Jun 30, 2019
@hjoliver hjoliver force-pushed the alt-run-dir-take-2-7.8.x branch from 36ea271 to 6461f5d Compare August 29, 2019 04:50
@hjoliver
Copy link
Member Author

I've finally finished this off. Ready for a quick second review (any volunteers?). See explanation in description of #2935.

@matthewrmshin matthewrmshin requested a review from wxtim August 29, 2019 09:22
@matthewrmshin
Copy link
Contributor

@wxtim please review 2.

@hjoliver
Copy link
Member Author

Back-ported registration test fixes #2935 (comment)

wxtim
wxtim approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made one comment but it's minor.

tests/registration/00-simple.t

CYLC_RUN_DIR="$(cylc get-global-config --print-run-dir)"

function make_rnd_suite() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that at the moment this is the only place this is used, but might these functions be better in test_header?

@wxtim wxtim merged commit 8ac7ae3 into cylc:7.8.x Aug 30, 2019
@hjoliver hjoliver deleted the alt-run-dir-take-2-7.8.x branch September 2, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@hjoliver hjoliver

Labels
None yet
Projects
None yet
Milestone
cylc-7.8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@hjoliver @matthewrmshin @wxtim