job.sh: run as bash only

[oliver-sanders]

Follow-up to #3088, use bash shebang for the job.sh file.

[dwsutherland]

Guess I can remove that “shell” info from the job fields in the UI feed..

[oliver-sanders]

Ooh, good point! See 881ad17.

[dwsutherland]

LGTM at a glance 😁

[kinow]

Change looks good!

Should we update the docs too?

diff --git a/doc/src/appendices/suiterc-config-ref.rst b/doc/src/appendices/suiterc-config-ref.rst
index 91385e60a..58d31d61f 100644
--- a/doc/src/appendices/suiterc-config-ref.rst
+++ b/doc/src/appendices/suiterc-config-ref.rst
@@ -1572,18 +1572,6 @@ job file path.
 - *example*: ``llsubmit \%(job)s``
 
 
-.. _JobSubShell:
-
-[runtime] ``->`` [[\_\_NAME\_\_]] ``->`` [[[job]]] ``->`` shell
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-Location of the bash shell invoked on job hosts to interpret task job scripts,
-if not installed in the standard location.
-
-- *type*: string
-- *root default*: ``/bin/bash``
-
-
 .. _JobSubRefRetries:
 
 [runtime] ``->`` [[\_\_NAME\_\_]] ``->`` [[[job]]] ``->`` submission retry delays
@@ -2015,7 +2003,7 @@ parser is concerned these are just normal configuration items).
 - *type*: string
 - *default*: (none)
 - *legal values*: depends to some extent on the task job
-  submission shell (:ref:`JobSubShell`).
+  submission shell
 - *examples*, for the bash shell:
 
   - ``FOO = $HOME/bar/baz``

[kinow]

Just kicked Travis to see if the build passes now 👍

[hjoliver]

Should we update the docs too? ...

So I see @oliver-sanders latest commit removes the remaining ability to configure the location of the bash interpreter, if 'not in the standard location' (left in when I removed ksh support a few days ago) ... in which case, yes the associated user-guide docs should be removed too.

So long as we can rely on bash always being located at /bin/bash. Presumably we can, in which case that's fine ... but just checking!

[hjoliver]

Note genuine test failure due to removal of the shell config item.

[oliver-sanders]

BTW: Happy to revert the last commit if desired.

So long as we can rely on bash always being located at /bin/bash. Presumably we can, in which case that's fine ... but just checking!

It hadn't occurred to me that that might be a problem. I'm not sure why this would happen, installing multiple bash versions?

Should we update the docs too?

Yes! About time we auto-generated this...