Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
[...]
in regexes, I believe we do not need to escape.
,:
,)
,<
,>
, etc. As far as I know, we need to escape only the closing]
, and the normal sequences like\n
,\r
,\t
.Python regex engine does the job of escaping these character anyway, but being regexes not always the fastest option, perhaps removing unnecessary escapes is a good idea?
Also included one more change (second commit) to use
([`\])
instead of(`|\)
. For two characters it makes no difference performance-wise. With more characters[`\]
would probably be faster. But it's still easier to read I think?Low priority, for Cylc 8 or later, without backport to Cylc 7 (I do not think it's necessary for the 7.8.x release series).
Cheers
Bruno