Remove remaining Cylc Review files #3024
Conversation
…view, as well as documentation mentioning it.
|
I believe this pull request is Cylc 8 only, without the need to backport to 7.8 branch. |
|
Found while reviewing External Triggers following up discussion in Riot. |
There was a problem hiding this comment.
I've reviewed & I am happy, so would otherwise approve & merge now, but I have noticed one other method we can drop, & it would be cleanest & easiest to include in this PR. If you don't mind can you update your code changes here to remove it, then I will approve & merge immediately?
| @@ -105,25 +105,6 @@ | |||
| # set CYLC_TEST_HOST and CYLC_TEST_OWNER for remote job tests. | |||
| # port_is_busy $PORT | |||
| # Return 0 if $PORT is busy or 1 if $PORT is not busy. | |||
| # cylc_ws_init $NS $UTIL | |||
There was a problem hiding this comment.
We can also now get rid of the port_is_busy method, which was only used across the test suite inside this cylc_ws_init method. (And now I have noticed it, we should drop the # tags on new line 580, just above where that method is defined, which was clearly for the aid of some developer who neglected to remove it. From git blame I can see that the developer in question was in fact myself 😬.)
There was a problem hiding this comment.
Good spot, thanks for reviewing it so quickly. Updating PR in a few moments. Thanks @sadielbartholomew !
There was a problem hiding this comment.
Hopefully removed the right lines here
There was a problem hiding this comment.
Excellent, thanks. Given the time in NZ I imagine you are no longer online so I have given two Travis CI jobs that were failing on flaky tests a kick. Once they pass I'll get this merged.
Complement to 3f7a601, removes the remaining files related to Cylc Review, as well as documentation mentioning it.
Checked if
TASK_STATUS_GROUPSwas used with the IDE, then withgrep, and finally confirmed where it was used before with ol':git log -S "TASK_STATUS_GROUPS" --patch.I think it should be safe to remove it too, as not used in the current code base. Hopefully not breaking anything in Travis-CI. Suite
fiveand all unit tests running OK locally.