Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest.ini: add ignores #2878

Merged
merged 1 commit into from
Nov 24, 2018
Merged

pytest.ini: add ignores #2878

merged 1 commit into from
Nov 24, 2018

Conversation

matthewrmshin
Copy link
Contributor

Ignore code based on optional dependencies: GTK, PyGraphviz and EmPy. Follow up of #2766.

@matthewrmshin
pytest.ini: add ignores
271f5c5 
Ignore code based on optional dependencies: GTK, PyGraphviz and EmPy.
@matthewrmshin matthewrmshin self-assigned this Nov 23, 2018
@matthewrmshin matthewrmshin added this to the next release milestone Nov 23, 2018
@matthewrmshin matthewrmshin requested a review from kinow November 23, 2018 12:54
@matthewrmshin
Copy link
Contributor Author

One review enough.

@kinow
Copy link
Member

kinow commented Nov 23, 2018

Just need to confirm that the empy file, when ignored, will still be covered in travis-ci. As travis has the library installed and is also using pytest.ini

@kinow
Copy link
Member

kinow commented Nov 24, 2018

Just had a look at Codecov, and graphing.py reduced the coverage, but it's not a lot, and this way we all can just run pytest 🎉 +1 LGTM thanks!

@kinow kinow merged commit 593e529 into cylc:master Nov 24, 2018
@matthewrmshin matthewrmshin deleted the add-pytest-ini-ignores branch November 24, 2018 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
cylc-7.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewrmshin @kinow