Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified fileparse._concatenate lines with continuation to raise if w… #2828

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Modified fileparse._concatenate lines with continuation to raise if w… #2828

merged 2 commits into from
Nov 8, 2018

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 31, 2018 •
edited by matthewrmshin
Loading

Fix #2780

@wxtim wxtim mentioned this pull request Oct 31, 2018
Closed
@matthewrmshin matthewrmshin added this to the next release milestone Oct 31, 2018
@matthewrmshin matthewrmshin added the bug Something is wrong :( label Oct 31, 2018
@wxtim wxtim force-pushed the C2780_broken_graph_line_fails_to_die2 branch from 55f4d2c to fc51f69 Compare October 31, 2018 16:03
@matthewrmshin
Copy link
Contributor

@oliver-sanders @kinow please review. (Or reassign reviewer to colleagues near you!)

@matthewrmshin matthewrmshin mentioned this pull request Nov 1, 2018
Closed
kinow
kinow reviewed Nov 1, 2018
View reviewed changes
@wxtim wxtim force-pushed the C2780_broken_graph_line_fails_to_die2 branch from ca75e66 to aed949b Compare November 5, 2018 10:20
oliver-sanders
oliver-sanders approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

hjoliver
hjoliver requested changes Nov 6, 2018
View reviewed changes
@wxtim
Modified fileparse._concatenate lines with continuation to raise if w…
f654ae2 
…hitespace after \

added test for raising failure for trailing whitespace

updated codestyle

simplified testing script

changed the fileparse.py's regex to one suggested by OS

regex corrected for pythong

corrected error message
@wxtim wxtim force-pushed the C2780_broken_graph_line_fails_to_die2 branch from aed949b to f654ae2 Compare November 6, 2018 09:40
hjoliver
hjoliver requested changes Nov 7, 2018
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small problem detected, otherwise good.

hjoliver
hjoliver approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wxtim

@hjoliver hjoliver merged commit 395e232 into cylc:master Nov 8, 2018
@wxtim wxtim deleted the C2780_broken_graph_line_fails_to_die2 branch September 5, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow left review comments

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-7.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxtim @matthewrmshin @kinow @hjoliver @oliver-sanders