Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote always in UTC #2723

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Fix remote always in UTC #2723

merged 2 commits into from
Jul 17, 2018

Conversation

matthewrmshin
Copy link
Contributor

This fixes remote commands running in UTC mode when UTC mode is False or not set.

@matthewrmshin matthewrmshin added the bug Something is wrong :( label Jul 13, 2018
@matthewrmshin matthewrmshin self-assigned this Jul 13, 2018
hjoliver
hjoliver approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although I'm not sure there's a need for the long time limit and timeout in the test suite?

@matthewrmshin
Copy link
Contributor Author

The long time out takes into account the remote nature of the test, but I agree that it is in general unnecessary.

sadielbartholomew
sadielbartholomew reviewed Jul 17, 2018
View reviewed changes
tests/job-submission/17-remote-localtime.t Outdated
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#-------------------------------------------------------------------------------
# Test remote host job log NN link correctness.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the description from the 02-job-nn-remote-host.t test which I guess was adapted to run with local not UTC time. Ideally update this heading for clarity before we merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another copy-and-paste failure. Sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment fixed.

sadielbartholomew
sadielbartholomew approved these changes Jul 17, 2018
View reviewed changes
Copy link
Collaborator

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suitable fix & appropriate test. Safe to merge as new feedback-response commit trivial.

@sadielbartholomew sadielbartholomew merged commit b98d85a into cylc:master Jul 17, 2018
@matthewrmshin matthewrmshin deleted the fix-remote-always-utc branch July 17, 2018 14:35
@matthewrmshin matthewrmshin mentioned this pull request Jul 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-7.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @hjoliver @sadielbartholomew