Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcylc: prevent negative job progress #2602

Merged
merged 1 commit into from
Mar 20, 2018
Merged

gcylc: prevent negative job progress #2602

merged 1 commit into from
Mar 20, 2018

Conversation

oliver-sanders
Copy link
Member

Fix unreproducible bug whereby the gui attempts to display a negative progress value when a task's status is juggled about via cylc reset, see traceback:

/data/local/fcm/cylc-7.5.0/lib/cylc/gui/view_tree.py:318: Warning: value "-43" of type `gint' is invalid or out of range for property `value' of type `gint'
  cell.set_property('value', percent)

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Mar 20, 2018
@oliver-sanders oliver-sanders added this to the next release milestone Mar 20, 2018
@oliver-sanders oliver-sanders self-assigned this Mar 20, 2018
@hjoliver hjoliver merged commit cc1cec8 into cylc:master Mar 20, 2018
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 26, 2018
@matthewrmshin
Selected back port to 7.6.x
4207e09 
* cylc#2606 Fix poll when job.status has no batch sys info
* cylc#2604 Lowercase for shell bool vars
* cylc#2603 Fix gui insert nested family
* cylc#2602 gcylc: prevent negative job progress
* cylc#2596 Fix ref by value of parameters with plus/minus
* cylc#2592 Permit syntax errors with trigger edits
* cylc#2588 Fix trigger --edit with host select
* cylc#2586 Fix gcylc zero division error from task mean elapsed time
* cylc#2585 Fix recovery of a failed host select command
* cylc#2579 Fix gscan exception hook dialog closure incapacity
* cylc#2574 Fix gscan host port range owner behaviour
* cylc#2571 gcylc: fix tailer of remote job log
@matthewrmshin matthewrmshin mentioned this pull request Mar 26, 2018
Merged
@oliver-sanders oliver-sanders deleted the gcylc-negative-percent branch May 18, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-7.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @matthewrmshin @hjoliver