Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place prompts above all windows. #2529

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

oliver-sanders
Copy link
Member

User request for the "Trigger edited task..." prompt to appear on-top of the gcylc window as it does not appear in the task-bar so can become difficult to re-locate once lost.

As the gui calls trigger and other commands via subprocess the prompts displayed are not associated with any parent window and so fancy trickery is not possible, we can, however, place the prompts above all windows.

This change affects the following commands:

  • hold
  • insert
  • kill
  • poll
  • release
  • reload
  • remove
  • reset
  • set
  • spawn
  • stop
  • trigger

@oliver-sanders oliver-sanders added this to the next release milestone Jan 8, 2018
@oliver-sanders oliver-sanders self-assigned this Jan 8, 2018
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as working.

@matthewrmshin matthewrmshin merged commit 36ce9c3 into cylc:master Jan 9, 2018
@oliver-sanders oliver-sanders deleted the gui-dialog-on-top branch May 18, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants