Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve doc and terminology #2501

Merged
merged 4 commits into from
Dec 9, 2017
Merged

Improve doc and terminology #2501

merged 4 commits into from
Dec 9, 2017

Conversation

matthewrmshin
Copy link
Contributor

Including:

@matthewrmshin
Improve doc and terminology
80a93af 
Including:
* "suite server program" instead of "suite daemon"
* "severity" instead of "priority" for logging and task messaging
* simple "ps" command instead of "pgrep" to list suite server program
@matthewrmshin matthewrmshin added this to the next release milestone Dec 4, 2017
@matthewrmshin matthewrmshin self-assigned this Dec 4, 2017
@matthewrmshin
Copy link
Contributor Author

matthewrmshin commented Dec 4, 2017 •
edited
Loading

Codacy's failure is nonsense in the context of this change. The same line is marked as fixed and new. (The change should be safer as we have plugged the STDIN hole to the external call.)

hjoliver
hjoliver approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

hjoliver
hjoliver approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(one minor change requested)

bin/cylc-message Outdated
choices=['NORMAL', 'WARNING', 'CRITICAL', 'CUSTOM'],
help="message priority: NORMAL, WARNING, or CRITICAL; default NORMAL.",
action="store", dest="priority", default="NORMAL")
help="message severity: NORMAL, WARNING, or CRITICAL; default NORMAL.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help message needs to include CUSTOM as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hjoliver hjoliver merged commit cba1d74 into cylc:master Dec 9, 2017
@hjoliver
Copy link
Member

hjoliver commented Dec 9, 2017

(evidently minor conflicts on other people's branches can be resolved via the GitHub web editor)

@matthewrmshin matthewrmshin deleted the improve-doc-terminology branch December 9, 2017 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
cylc-7.6.0
3 participants
@matthewrmshin @hjoliver @oliver-sanders