Set default task comms to client server comms. #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(It remains near impossible to effectively test remote job host interaction under all scenarios). |
hjoliver
commented
Nov 8, 2017
| @@ -529,6 +529,9 @@ def get_host_item(self, item, host=None, owner=None, replace_home=False, | |||
| if owner_home is None: | |||
| owner_home = os.path.expanduser('~%s' % owner) | |||
| value = value.replace(os.environ['HOME'], owner_home) | |||
| if item == "task communication method" and value == "default": | |||
| # Translate "default" to client-server comms: "https" or "http". | |||
| value = cfg['communication']['method'] | |||
There was a problem hiding this comment.
(In #2464 auth files are only copied over if task comms method starts with "http" - but the value was "default"! - which refers to the general client/server comms method)
There was a problem hiding this comment.
I've checked the codebase and I don't see any code that relies on the value being "default".
There was a problem hiding this comment.
I have just been bitten by this one while testing #2468.
|
Travis CI timed out around the 49 minute mark again - there were not test errors prior to that. I just restarted the build... |
matthewrmshin
approved these changes
Nov 9, 2017
oliver-sanders
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago, #2464 broke installation of auth files to job hosts (w/o shared FS).